Add support for optionally returning the Plotly JSON string #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for the web interface because the JSON string needs to be sent to the browser.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 74.81% 74.82%
=======================================
Files 32 32
Lines 4892 4893 +1
=======================================
+ Hits 3660 3661 +1
Misses 1232 1232 ☔ View full report in Codecov by Sentry. |
|
(sneakily bumped the API version in 3aaed41 so this'll hit pypi after merging) |
|
Thanks for the quick PR, James! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for the web interface because the JSON string needs to be sent to the browser.
CC @CammilleCC